Skip to content

Add affected_rows to sql.active_record#1268

Merged
aidanharan merged 3 commits intomainfrom
instrument-affected-rows
Dec 11, 2024
Merged

Add affected_rows to sql.active_record#1268
aidanharan merged 3 commits intomainfrom
instrument-affected-rows

Conversation

@aidanharan
Copy link
Copy Markdown
Contributor

@aidanharan aidanharan commented Dec 9, 2024 •
edited
Loading

Fix ActiveRecord::InstrumentationTest#test_payload_affected_rows.

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/12275600971/job/34250983451

  3) Failure:
ActiveRecord::InstrumentationTest#test_payload_affected_rows [/usr/local/bundle/bundler/gems/rails-7bb8fe2d4e98/activerecord/test/cases/instrumentation_test.rb:173]:
Expected: [4, 3, 2, 0]
  Actual: [0, 0, 0, 0]

Ref: rails/rails#53277

@aidanharan aidanharan marked this pull request as ready for review December 11, 2024 18:27
@aidanharan aidanharan merged commit a1bc145 into main Dec 11, 2024
@aidanharan aidanharan deleted the instrument-affected-rows branch December 11, 2024 18:28
@taylorthurlow taylorthurlow mentioned this pull request Feb 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

rails-8.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@aidanharan